feat: new helper function fetchImportMaps#358
Merged
Conversation
Centralize the code for fetching import maps, which right now is duplicated (poorly) in five different modules.
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2025
# [5.1.0](v5.0.4...v5.1.0) (2025-05-08) ### Features * new helper function fetchImportMaps ([#358](#358)) ([0f89645](0f89645))
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize the code for fetching import maps, which right now is duplicated (poorly) in five different modules. I mapped out the dependencies of the developer tools and they all use
common.Followup to:
Turns out we have this bug in
webpack-pluginas well, and similarfetch-based code ineslint-pluginandpostcss-plugin. Let's centralize the code and tests for this in one location so we don't have to duplicate all the different error messages and such.After discussing with @digitalsadhu we agreed
undiciis overkill here, and we can just usefetch. It follows redirects by default, apparently up to 20.